Skip to content

London |ITP- Jan-2026| Damian Dunkley |Sprint 3 |Alarm Clock app#1028

Open
DamianDL wants to merge 9 commits intoCodeYourFuture:mainfrom
DamianDL:Sprint-3
Open

London |ITP- Jan-2026| Damian Dunkley |Sprint 3 |Alarm Clock app#1028
DamianDL wants to merge 9 commits intoCodeYourFuture:mainfrom
DamianDL:Sprint-3

Conversation

@DamianDL
Copy link

@DamianDL DamianDL commented Mar 17, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Updated code to :

  1. Convert input of minutes and Seconds to Seconds,
  2. Include dynamic countdown of timeRemaining
  3. Set the alarm
  4. Validate that input is numeric , finite and not null,
  5. Countdown Alarm to zero. Play sound and change screen colour.

Questions

Please review for Data Groups module?

@DamianDL DamianDL added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. javascript Pull requests that update javascript code labels Mar 17, 2026
@hkavalikas hkavalikas added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 22, 2026
@hkavalikas hkavalikas self-requested a review March 22, 2026 11:47
@hkavalikas
Copy link

There is a requirement to update the title of the page to Alarm clock app that was missed, let's address that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely optional and can be personal preference but we might have over-commented some of the lines, some comments are genuinely useful and are great to document code but others might be consider self explanatory.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're right about style- I have put most of the comments in as a reminder to myself when I look at it again- not very neat and collaborative, but useful for me while I'm learning and possibly reusing in future modules. If there's a better or more standard way of doing that, I'm happy to comply? Thanks

clearInterval(countdownId);
countdownId = null;
playAlarm();
document.body.style.backgroundColor = "red"; // change background colour

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome touch, minor point is that when the background becomes red, then a new timer could reset it back to the original background (until it's done counting and it goes back to red). How can we implement that?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset screen to white when timer set.

}

function setAlarm() {
const input = document.getElementById("alarmSet");// Get the input element using its DOM ID

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely optional, can we add some guards against edge cases such as empty input, negative values, and (potentially) 0? Everything would trigger an alarm right away with the current implementation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated edge cases of 0 and -1 to not accept inputs.

@hkavalikas hkavalikas added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Mar 22, 2026
@DamianDL DamianDL changed the title London |ITP- Jan-2026| Damian Dunkley |Sprint 3 |Alarm Clock London |ITP- Jan-2026| Damian Dunkley |Sprint 3 |Alarm Clock app Mar 24, 2026
@DamianDL DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 24, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026
@github-actions

This comment has been minimized.

@DamianDL DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026
@DamianDL DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 24, 2026
@hkavalikas
Copy link

Let's address the github action @DamianDL

@DamianDL DamianDL added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 25, 2026
@DamianDL
Copy link
Author

Github action addressed- I hope. Passing script and I hope all changes to alarmclock.js retained. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code Module-Data-Groups The name of the module. Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants